-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sendTokensToHubPool script to test finalizations #574
Open
bmzig
wants to merge
7
commits into
master
Choose a base branch
from
bz/testFinalizationScript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Signed-off-by: bennett <[email protected]>
Example output:
|
Not sure how automated we want this. Some bridges will require the EOA to send a |
bmzig
changed the title
[WIP] feat: create mock spoke pool to test for finalizations
feat: create mock spoke pool to test for finalizations
Aug 7, 2024
bmzig
changed the title
feat: create mock spoke pool to test for finalizations
feat: add sendTokensToHubPool script to test finalizations
Aug 7, 2024
Signed-off-by: bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intended strategy is to deploy two copies of the spoke pool for each chain, but for one spoke pool, set the
crossDomainAdmin
as the L1 chain adapter and thehubPool
as theMOCK_ADMIN
address. Ideally, this would allow us to submit an empty relayer refund root with a nonzeroamountToReturn
, since theonlyAdmin
modifier will succeed in this setup, and calling_bridgeTokensToHubPool
will send these funds back to our EOA. For completeness, the withdrawal should be triggered by the finalizer.