refactor: clean TS errors, add TS rules, cmn types #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
reviewed
Apr 9, 2024
| @@ -81,7 +87,8 @@ const parseShareIntent = (value, options): ShareIntent => { | |||
| type: isMedia ? "media" : "file", | |||
| }; | |||
| } | |||
| options.debug && console.debug("useShareIntent[parsed] ", result); | |||
| options.debug && | |||
| console.debug("useShareIntent[parsed] ", JSON.stringify(result, null, 4)); | |||
achorein
force-pushed
the
small-updates-to-expo-share-intent
branch
from
041f784
to
4bed6a0
Compare
|
@ChristopherGabba I updated this PR, is that fine for you ? |
achorein
changed the title
There was a problem hiding this comment.
Thanks @achorein, I appreciate you giving me a few wins on my first commit ever, looks good. :)
achorein
changed the title
achorein
added a commit
that referenced
this pull request
Apr 19, 2024
* refactor: clean TS errors, add TS rules, cmn types --------- Co-authored-by: Anselme Chorein <[email protected]> Co-authored-by: achorein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is my first PR to an open source project ever, so feel free to shoot down.
Trying to keep this PR small and management because I'm still learning. Feel free to shut down this PR.
Todo
I added some TODO text to the types that eventually would be ideal to clean up and get one common type. I'm not bold enough to mess with the native code yet.
Issue
No Github issues. Just trying to add some comments and be helpful.