feat: add meta info (like title) to share intent object on Android #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
reviewed
Apr 8, 2024
|
@achorein I've implemented your changes. Good call on adding to the other example projects, I forgot about that. Anything else we can optimize here? |
|
Looks good to me 👍 |
achorein
pushed a commit
that referenced
this pull request
Apr 11, 2024
* feat: add meta info (like title) to share intent object on android * docs: add meta object documentation to README.md * refactor: change type to interface and add example meta to example apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When sharing a link on Android, the browser adds the page title to the share intent. This is stored in the
Intent.EXTRA_TITLEproperty. The library currently has no way of accessing this extra information. This PR adds ametaobject to the share intent with atitleproperty. This way consumers of the library can access thetitleproperty in their code. On iOS the meta object will be empty.The code has been set up so it's easily extendible. It will be a small change to add another extra property.
Todo
Issue
fixes: #38