Fix #20 and CMake simplifications #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define preprocessor variable `NDEBUG=1`, when CMAKE_BUILD_TYPE is not Debug (cause issue achille-roussel#20) - fix overflowing buffer in test_message with strcpy. strcpy also copied terminating '\0', which lead to length 13 (buffer overflow) and failiure of nnxx_check() in test_message.cpp, l. 49 - simplify detection of test case locations in CMake - more convenient output directory locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDEBUG=1, when CMAKE_BUILD_TYPE is notDebug (cause issue Test #1: message ***Failed #20)
strcpy also copied terminating '\0', which lead to length 13 (buffer
overflow) and failiure of nnxx_check() in test_message.cpp, l. 49