polkadot-parachain-primitives should not depend on frame-support. (…

…paritytech#1897) This PR does not make any functional changes to the code. Rather, it restructures the dependency graph. Before this PR, the crate `polkadot-parachain-primitives` depended directly on the crate `frame-support`. This is wrong in principal because a parachain does not necessarily have anything to do with frame. This dependency was only for the `Weight` type which was just a re-export from `sp-weights` anyway. So this PR changes the dependency to be directly on the much lighter `sp-weights`. --------- Co-authored-by: Joshy Orndorff <[email protected]> Co-authored-by: command-bot <>
acatangiu · Oct 25, 2023 · bdf1868 · bdf1868
1 parent f6560c2
commit bdf1868
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/polkadot/parachain/Cargo.toml b/polkadot/parachain/Cargo.toml
@@ -15,7 +15,7 @@ scale-info = { version = "2.10.0", default-features = false, features = ["derive
 sp-std = { path = "../../substrate/primitives/std", default-features = false }
 sp-runtime = { path = "../../substrate/primitives/runtime", default-features = false, features = ["serde"] }
 sp-core = { path = "../../substrate/primitives/core", default-features = false, features = ["serde"] }
-frame-support = { path = "../../substrate/frame/support", default-features = false }
+sp-weights = { path = "../../substrate/primitives/weights", default-features = false }
 polkadot-core-primitives = { path = "../core-primitives", default-features = false }
 derive_more = "0.99.11"
 bounded-collections = { version = "0.1.8", default-features = false, features = ["serde"] }
@@ -28,16 +28,13 @@ default = [ "std" ]
 wasm-api = []
 std = [
 	"bounded-collections/std",
-	"frame-support/std",
 	"parity-scale-codec/std",
 	"polkadot-core-primitives/std",
 	"scale-info/std",
 	"serde/std",
 	"sp-core/std",
 	"sp-runtime/std",
 	"sp-std/std",
+	"sp-weights/std",
 ]
-runtime-benchmarks = [
-	"frame-support/runtime-benchmarks",
-	"sp-runtime/runtime-benchmarks",
-]
+runtime-benchmarks = [ "sp-runtime/runtime-benchmarks" ]
diff --git a/polkadot/parachain/src/primitives.rs b/polkadot/parachain/src/primitives.rs
@@ -20,12 +20,12 @@
 use sp_std::vec::Vec;
 
 use bounded_collections::{BoundedVec, ConstU32};
-use frame_support::weights::Weight;
 use parity_scale_codec::{CompactAs, Decode, Encode, MaxEncodedLen};
 use scale_info::TypeInfo;
 use serde::{Deserialize, Serialize};
 use sp_core::{bytes, RuntimeDebug, TypeId};
 use sp_runtime::traits::Hash as _;
+use sp_weights::Weight;
 
 use polkadot_core_primitives::{Hash, OutboundHrmpMessage};