feat: add filter for read #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new read function that allows specifying a list of resource keys to act as a filter for the returned results. The same can be achieved using the existing functions: - Using Read multiple times by requesting a next resource on each iteration. The difference with the proposed solution is that ReadFiltered keeps a mutex open and so avoids nonrepeatable reads. - Using ReadAll and filtering on the client side. This is likely just wasteful as it fetches all the records regardless of the selection that the client requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new read function that allows specifying a list of resource keys to act as a filter for the returned results.
The same can be achieved using the existing functions: