Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently refactoring and making changes to interface. Doing bug fixes. #3

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

SpinnerX
Copy link
Contributor

@SpinnerX SpinnerX commented Nov 9, 2022

In this commit, I am pushing out some changes that I have already done. Currently making some more changes to the interface.

Copy link
Collaborator

@MattHazard MattHazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When browsing for a file, entering a choice, and then clicking the save button. The filepath text box does not update with the new choice.


// When "Save Changes" button is clicked, the given inputted information is updated
// Little redundant, for now was trying to get interface working with updating the JTable.
// When "Submit changes" button is clicked, the given inputted information is updated
private void updateTable(){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should call my function but I can write that in myself when I pull this since I'll be testing it.

@MattHazard
Copy link
Collaborator

When browsing for a file, entering a choice, and then clicking the save button. The filepath text box does not update with the new choice.

To elaborate, you aren't setting the text box in your loadfile function with the new file path.

Copy link
Collaborator

@MattHazard MattHazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be careful about the messages of your commits. Even if it is small changes forgotten in a previous one, the commit message should still describe the current changes.

@SpinnerX
Copy link
Contributor Author

Okay, thank you for the feedback. I will be making these changes as soon as possible!

@SpinnerX SpinnerX closed this Dec 27, 2022
@SpinnerX SpinnerX reopened this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants