Fix input/output size in staticcall for addition and scalar_mul #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark64
commented
Apr 15, 2024
| @@ -481,7 +481,7 @@ library Pairing { | |||
| input[2] = s; | |||
| bool success; | |||
| assembly { | |||
| success := staticcall(sub(gas(), 2000), 7, input, 0x80, r, 0x60) | |||
| success := staticcall(sub(gas(), 2000), 7, input, 0x60, r, 0x40) | |||
There was a problem hiding this comment.
https://github.com/ethereum/go-ethereum/blob/master/core/vm/contracts.go#L488
Bn256ScalarMul takes 96 bytes (0x60) and outputs G1 which is 64 bytes (0x40)
dark64
commented
Apr 15, 2024
| @@ -456,7 +456,7 @@ library Pairing { | |||
| input[3] = p2.Y; | |||
| bool success; | |||
| assembly { | |||
| success := staticcall(sub(gas(), 2000), 6, input, 0xc0, r, 0x60) | |||
| success := staticcall(sub(gas(), 2000), 6, input, 0x80, r, 0x40) | |||
There was a problem hiding this comment.
https://github.com/ethereum/go-ethereum/blob/master/core/vm/contracts.go#L446
Bn256Add takes 128 bytes (0x80) and outputs G1 which is 64 bytes (0x40)
Schaeff
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1364, merge after #1369
Note: This is not a huge issue as the sizes are clamped in the precompile to the correct values anyways (see here)