Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICC-DBS: warn when Blood Beast hit swing (Fix #197) #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zidras
Copy link
Owner

@Zidras Zidras commented Feb 6, 2024

Still missing locales

@anzz1
Copy link

anzz1 commented Feb 9, 2024

If I'm looking at the code correctly, this only warns the player being hit.

If you know the encounter (DBS @ ICC), running away isn't an option and the person getting hit isn't really the root of the trouble in most cases, but the CC'ers and RDPS in the raid. So the notification should be raid-wide, not just the person getting hit.

@Zidras
Copy link
Owner Author

Zidras commented Feb 9, 2024

This will never be raid wide warning, since spam goes against my vision of a spam free dbm

@Zidras Zidras force-pushed the main branch 2 times, most recently from 333b7ca to 0ccb47a Compare July 5, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants