Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniq partition algorithm #17

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

fxfxfxfxfxfxfxfx
Copy link
Collaborator

No description provided.

@Zhaoyilunnn
Copy link
Owner

Zhaoyilunnn commented Apr 6, 2024

You could directly update your code in your forked repository. And the pull request will be automatically updated.
In general, this PR looks good to me.
You might need to update the type hint -> list[int] to -> List[int], where List can be imported through from typing import List, to fix the unit test error: https://github.com/Zhaoyilunnn/qdao/actions/runs/8579560132/job/23514676846?pr=17

tests/qdao/engine_test.py:12: in <module>
    from qdao.circuit import BaselinePartitioner
qdao/__init__.py:1: in <module>
    from .engine import Engine
qdao/engine.py:7: in <module>
    from qdao.circuit import (
qdao/circuit.py:116: in <module>
    class DependencyMatrix:
qdao/circuit.py:200: in DependencyMatrix
    def select_subcircuit(self, active_qubit_num: int) -> (list[int], int):
E   TypeError: 'type' object is not subscriptable

You could also turn on the actions button in your repository, thus everytime you push to your repository, the unit test will also run

@Zhaoyilunnn Zhaoyilunnn merged commit 7c54f92 into Zhaoyilunnn:main Apr 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants