Make compile-sketch great again #531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorArkwolf
changed the title
|
I have a feeling that sonar wont run for me as I don't have access to the private key from my repo. |
MajorArkwolf
force-pushed
the
fix/pcb_not_building
branch
from
a2cd997
to
8bad884
Compare
MajorArkwolf
requested review from
Zer0-bit,
kstam and
matiasjrossi
as code owners
|
Sorry this branch is obsolete as the code is being handled in a private repo for now, i'll merge it back "soon" and you can have another look if interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sonar-scannar as a dependent job and removed the need for the weird intermediate step of having a build output folder. This also means that anyone who forks this repo can at least run the compilation actions as sonar requires secrets that wont be present in forks.