Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php82 fixes #66

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Php82 fixes #66

wants to merge 2 commits into from

Conversation

mschering
Copy link
Contributor

Released under the GNU Affero General Public License (AGPL), version 3

Some PHP 8.2 compatibility fixes.

@matidau
Copy link
Collaborator

matidau commented Aug 1, 2024

@mschering Thanks for the PR, sorry it's taken me so long to get to it.

z-push-top in develop isn't causing me any PHP 8.2 errors, for the most part I think your changes might be implementation dependent with the backend your using. Could be wrong let me know your thoughts.

For the serialization, this is an issue, thank you for raising it. Your commit is causing an error with the state files. Example from the log:

01/08/2024 15:56:52 [1229260] [WARN] [[email protected]] /usr/local/lib/z-push/lib/utils/utils.php:1466 Erroneous data format for unserializing 'StateObject' (2)
01/08/2024 15:56:52 [1229260] [WARN] [[email protected]] /usr/local/lib/z-push/lib/utils/utils.php:1466 unserialize(): Error at offset 22 of 2493 bytes (8)
01/08/2024 15:56:52 [1229260] [WARN] [[email protected]] FileStateMachine->GetState(): Failed on unserializing filename '/var/lib/z-push/9/1/androidc1307007219-devicedata' - attempt: 1
01/08/2024 15:56:52 [1229260] [FATAL] [[email protected]] FileStateMachine->GetState():Unable to unserialize filename '/var/lib/z-push/9/1/androidc1307007219-devicedata' after 1 attempts

Cheers,
Mat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants