Implement AS 16 Find command to fix e-mail search on iOS 16+ #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck) of type string is deprecated
|
PHP 8.2 changes, if needed, should not be in an AS16.1 ticket. You should open a seperate issue for that. |
I agree with this, though I think some of it only relates to changes after AS16.1 has been made. To muddy the waters I was also working on AS16.1 changes last year for Kopano based on grommunio-sync #59 |
|
I agree, I added those by mistake. I'll figure out how to remove those from here. |
|
I've created a new branch for this pull request without that last commit and opened a new pull request: I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
iOS 16 and up wrongfully sends a Find command when searching mail using Z-Push. I implemented the Find command so that searching works on iOS 16.
Does this close any currently open issues?
Fixes Error when searching mail on iphone #23
Any relevant logs, error output, etc?
No
Where has this been tested?
Server (please complete the following information):
Smartphone (please complete the following information):