apicula: add support for magic sip pins #1370
Draft
+64
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
reviewed
Sep 20, 2024
| bool gowin_apply_constraints(Context *ctx, std::istream &in) | ||
| { | ||
| // implicit constraints from SiP pins | ||
| const Extra_package_data_POD *extra = reinterpret_cast<const Extra_package_data_POD *>(ctx->package_info->extra_data.get()); | ||
| if(extra != nullptr) { |
There was a problem hiding this comment.
this won't actually work, because relptrs are relative so get() will add it's own location to the zero offset first. you'd need to add something like an is_null() or similar function to RelPtr that checks if the offset is zero (because a relptr is never going to be pointing to itself in any useful context, so zero is useful as a null offset value)
gatecat
reviewed
Sep 20, 2024
| @@ -240,8 +240,31 @@ struct GowinCstReader | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| void add_sip_constraints(Context *ctx, const Extra_package_data_POD *extra) { | |||
There was a problem hiding this comment.
this can be static void or in an anonymous namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have documented the sdram pins of some devices we lack the ability to automatically place them like the vendor tools do. For better compatibility and user friendliness this PR adds the ability to constrain these magic pin locations.
It seems to load the constraints but I have yet to test if sdram actually functions, which isn't super trivial.