YoastCS: add extra WP related rules #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bugs There is one known bug in the `WordPressVIPMinimum.Hooks.AlwaysReturnInFilter` sniff related to a redirect being done from within the filter. This has been reported upstream Automattic/VIP-Coding-Standards 719. Related to 303 Fixes 229 Impact on Yoast packages: | Plugin/Tool | Errors/Warnings | |-------------------|-----------------| | PHPUnit Polyfills | -- | WP Test Utils | -- | YoastCS | -- | WHIP | -- | Yoast Test Helper | -- | Duplicate Post | -- | Yst ACF | -- | Yst WooCommerce | -- | Yst News | -- | Yst Local | 2 (proper escaping) | Yst Video | -- | Yst Premium | 1 (false positive/reported bug) | Yst Free | 2 (1 false positive/reported bug) Note: these rules were previously already "silently" enforced via clean-up sweeps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: add Automattic VIP sniffs requirement
YoastCS rules: add a few VIP sniffs to prevent some typical WP compat bugs
There is one known bug in the
WordPressVIPMinimum.Hooks.AlwaysReturnInFiltersniff related to a redirect being done from within the filter.This has been reported upstream Automattic/VIP-Coding-Standards#719.
Related to #303
Fixes #229
Impact on Yoast packages:
Note: these rules were previously already "silently" enforced via clean-up sweeps.