Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer/PHPCS: update to YoastCS 3.0.0 #373

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Composer/PHPCS: update to YoastCS 3.0.0 #373

merged 2 commits into from
Dec 16, 2023

Commits on Dec 16, 2023

  1. Composer/PHPCS: update to YoastCS 3.0.0 

    YoastCS 3.0.0 has been released and is based on WordPressCS 3.0.0.

This commit makes the necessary updates for that:
* Composer: update the requirements.
* PHPCS ruleset:
    - Enforce strict PSR-4 for the tests.
    - Remove some configuration which is now handled by YoastCS.
    - Remove a few exclusions which are no longer needed.
* GHA CS workflow: run the CS check on the latest PHP version.
        No need to run on PHP 7.4 any more as the deprecations previously encountered were all fixed.

Refs:
* https://github.com/Yoast/yoastcs/releases/tag/3.0.0
* https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/3.0.0
    @jrfnl
    jrfnl committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    1424840 View commit details
    Browse the repository at this point in the history

  2. GH Action/cs: use the threshold/branch report 

    ... instead of a full scan.

As there are some YoastCS 3.0 issues which still need to be solved by the teams, this changes the CS workflow to use the threshold report instead of expecting a 100% clean code base.
    @jrfnl
    jrfnl committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    36fe88d View commit details
    Browse the repository at this point in the history