Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: remove redundant CLI argument from scripts #363

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 24, 2023

Summary

This PR can be summarized in the following changelog entry:

  • QA

Relevant technical choices:

CLI arguments should either be encoded in the config file or set by the dev-user. This is neither here nor there.

Test instructions

This PR can be tested by following these steps:

  • N/A

@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Nov 24, 2023
@jrfnl jrfnl added this to the 3.2 milestone Nov 24, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6985605952

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.274%

Totals Coverage Status
Change from base Build 6925901472: 0.0%
Covered Lines: 148
Relevant Lines: 263

💛 - Coveralls

@jrfnl jrfnl merged commit f55cf99 into develop Nov 24, 2023
16 checks passed
@jrfnl jrfnl deleted the JRF/misc branch November 24, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants