Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: enable linting and testing against PHP 8.3 #361

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 20, 2023

Summary

This PR can be summarized in the following changelog entry:

  • The plugin has no known incompatibilities with PHP 8.3

Relevant technical choices:

  • As the PHP 8.3 builds pass and the PHP 8.3 release is expected later this week, the builds are not allowed to fail.
  • Update PHP version on which code coverage is run (high should now be 8.3 what with the release this week).

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A If the builds pass, we're good.

* As the PHP 8.3 builds pass and the PHP 8.3 release is expected later this week, the builds are not _allowed to fail_.
* Update PHP version on which code coverage is run (high should now be 8.3 what with the release this week).
@jrfnl jrfnl added yoast cs/qa changelog: other Needs to be included in the 'Other' category in the changelog labels Nov 20, 2023
@jrfnl jrfnl added this to the 3.2 milestone Nov 20, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6925856769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.274%

Totals Coverage Status
Change from base Build 6925841856: 0.0%
Covered Lines: 148
Relevant Lines: 263

💛 - Coveralls

@jrfnl jrfnl merged commit fc188ed into develop Nov 20, 2023
14 checks passed
@jrfnl jrfnl deleted the JRF/ghactions-run-against-php83 branch November 20, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants