Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21610 deprecate and remove jetpack boost ad code #21613

Merged
merged 13 commits into from
Sep 11, 2024

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Sep 9, 2024

Context

  • Revome jetpack boost ad and integration card.

Summary

This PR can be summarized in the following changelog entry:

  • Remove unreleased jetpack ad code.

Relevant technical choices:

  • I did not deprecated the classes since those ads were never released and are meant for internal use.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

These are more regression tests:

  • Go to integration page and check there are no console errors.
  • Edit a post in the block editor and check you get no console errors.
  • install Jetpack boost and repeat those steps.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #21610

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 9, 2024
@igorschoester igorschoester force-pushed the 21610-deprecate-and-remove-jetpack-boost-ad-code branch from 6b4d99a to daa350e Compare September 11, 2024 06:18
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester merged commit 9ef5595 into trunk Sep 11, 2024
34 checks passed
@igorschoester igorschoester deleted the 21610-deprecate-and-remove-jetpack-boost-ad-code branch September 11, 2024 06:24
@igorschoester igorschoester added this to the 23.6 milestone Sep 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0aab1fa4eb16e5b29a333db0fcfcc179f1f72cc2

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 54.717%

Totals Coverage Status
Change from base Build 6fc322255e9fa38f96f1a322033c1f32e66e1c1d: 5.2%
Covered Lines: 29746
Relevant Lines: 54609

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Jetpack boost ad code
3 participants