Remove default mounting of /etc/pki/spark #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed that this was a thing that we did in my previous PR to always set k8s mounts regardless of whether or not they exist on the host executing service_configuration_lib code - however, my assertion that in the worst case the container runtime would create the missing files wherever these mounts are used was incorrect: in a `paasta spark-run`, the spark driver will run locally and re-use the k8s volume functions to figure out what needs to be mounted. This would normally be fine, but we have a security setup that prevents writes at certain paths: of which /etc/pki is in the set of blocked paths. Since we no longer have a spark cluster that is able to use certificate-based k8s authentication, this should be totally safe to remove as a default.
88manpreet
approved these changes
Sep 11, 2024
chi-yelp
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that this was a thing that we did in my previous PR to always set k8s mounts regardless of whether or not they exist on the host executing service_configuration_lib code - however, my assertion that in the worst case the container runtime would create the missing files wherever these mounts are used was incorrect: in a
paasta spark-run, the spark driver will run locally and re-use the k8s volume functions to figure out what needs to be mounted.This would normally be fine, but we have a security setup that prevents writes at certain paths: of which /etc/pki is in the set of blocked paths.
Since we no longer have a spark cluster that is able to use certificate-based k8s authentication, this should be totally safe to remove as a default.