Add Max Acceleration Yaw Offset #101
Conversation
|
I think this state should be good. If there's anything I would like to add that would be knowing the yaw speed of previous frame so the current s4x or s5x can continue on that number. Maybe add it now. Maybe add it later. I guess we'd never know. Edit: Need YaLTeR/BunnymodXT#521 |
| @@ -1870,6 +1887,13 @@ fn add_frame_bulk_hud_lines(text: &mut Vec<u8>, bulk: &FrameBulk) { | |||
| StrafeType::ConstYawspeed(yawspeed) => { | |||
| write!(text, "turn rate: {yawspeed:.0}").unwrap(); | |||
| } | |||
| StrafeType::MaxAccelYawOffset(start, target, accel) => { | |||
| // The values are so tiny that only this would make it sensible. | |||
There was a problem hiding this comment.
This is better than just showing them with 2 digits? It could be confusing I guess
There was a problem hiding this comment.
Here is a sample part where I use it.
s51-------|------|------|0.010000001|- -5.4011025 -5.4011025 0|-|43
s51-------|------|------|0.010000001|- -5.635861 -5.635861 0|-|268
s50-j-----|------|------|0.010000001|- -0.70690674 -0.70690674 0|-|134
s50-j-----|------|------|0.010000001|- -2.2149327 -2.597555 0|-|19
s51-j-----|------|------|0.010000001|- -0.59532917 -0.59532917 0|-|169
s50-j-----|------|------|0.010000001|- -10.585796 -1.0256441 0.12860943|-|982
s01-j-----|------|------|0.010000001|-|-|221
s50-j-----|------|------|0.010000001|- -9.952005 -0.9520051 0.1|-|941
s50-j-----|------|------|0.010000001|- -0.13668747 -0.13668747 0|-|199
s51-j-----|------|------|0.010000001|- 0.32988316 -0.29589385 0|-|295
s51-j-----|------|------|0.010000001|- 2.9388967 4.460467 0|-|7
s51-j-----|------|------|0.010000001|- 2.9388967 4.460467 0|-|72
I think 2 digits (times 10) might not be descriptive enough. And also we have space for 3.
src/modules/tas_studio/editor/mod.rs
Outdated
| ) | ||
| } | ||
| _ => return Err(ManualOpError::UserError( | ||
| "Max accel yaw offset does not support current strafe dir." |
There was a problem hiding this comment.
Point strafing isn't supported for editor operations because that would adds some more complexity (and effort). I think the message is misinformed. I will change that.
khanghugo
force-pushed
the
accelerated-yawspeed
branch
from
a85ab62
to
171d197
Compare
|
Also waiting for this BXT change YaLTeR/BunnymodXT#519 (comment) I added optimizer support a while ago but I forgot to push so it is now here. |
khanghugo
force-pushed
the
accelerated-yawspeed
branch
from
e7de77a
to
a2a5a0c
Compare
|
Need hltas update and that's it |
|
Thanks |
Needs hltas update.
There are some things about this. First, I want that when a frame bulk of this type is split, it shouldn't reset the acceleration values. That is why the weird gymnastics is here.
Second, I want it a bit easier to use so there's text popping up like #100 . I think it is pretty okay. I don't think the console command for this would be that necessary.
No third point but I don't want to pass "accurate" data, specifically the current accumulated yawspeed, from BXT to bxt-rs because I think bxt-strafe won't ever mess it up.
I play around with it for a bit and it is very confusing to use. Might get some time getting used to because you have two parameters. I put some thoughts into the interactions and I think it works great for me. Not sure about others.