helper_functions: added IsPlayer and Center own implementations to not rely on hooked virtual functions #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntity is a player
…d with its own function
…with its own function
YaLTeR
reviewed
Jul 27, 2024
Comment on lines
+17
to
+18
| if (!(ent->v.flags & FL_CLIENT)) | ||
| return false; |
There was a problem hiding this comment.
I'd move this above the strcmp because it's a much cheaper check.
| void *pToucher = pevToucher->pContainingEntity->pvPrivateData; | ||
| _IsPlayer IsPlayerFunc = *reinterpret_cast<_IsPlayer *>(*reinterpret_cast<uintptr_t *>(pToucher) + offFuncIsPlayer); | ||
| if (!IsPlayerFunc(pToucher)) | ||
| if (!helper_functions::IsPlayer(pevToucher->pContainingEntity)) |
There was a problem hiding this comment.
I'd squash this commit into the previous one
|
|
||
| Vector playerCenter; | ||
| Vector inflictorCenter; | ||
| entvars_t *pev = *reinterpret_cast<entvars_t**>(reinterpret_cast<uintptr_t>(thisptr) + 4); // _Smiley: TODO: replace it with GET_PEV macro once it's merged. |
There was a problem hiding this comment.
Same, I'd squash. And now you can GET_PEV too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want an answer, is it really necessary to overloading the same function first with each individual argument, and then only with
edict_tas an argument? I'll answer yes, because it solves two issues at once:edict_t: you can simply give only the edict as input, and the rest the function will do everything for you, wonderful, isn’t it?edict_tAlso In case someone wants to merge it if I would inactive for a while: simply rebase to the latest master as soon as #531 is merged to solve the build errors