Add bxt-rs camera replay related hooks #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Jul 6, 2024
| @@ -32,6 +32,7 @@ struct on_tas_playback_frame_data { | |||
| unsigned strafe_cycle_frame_count; | |||
| std::array<float, 4> prev_predicted_trace_fractions; | |||
| std::array<float, 4> prev_predicted_trace_normal_zs; | |||
| std::array<float, 3> rendered_viewangles; | |||
| }; | |||
|
|
|||
| // Change the variable name if you change the parameters! | |||
There was a problem hiding this comment.
I guess this is the time when we need to change the name. I already forgot what I meant by "variable", but we can change the function name to bxt_on_tas_playback_frame_v2 since the ABI changes with the addition of a field in the struct.
There was a problem hiding this comment.
Right, as soon as #521 is merged then I can make changes to this (without weird conflicts)
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For YaLTeR/bxt-rs#99
Though might need #518 merged first because this uses variables from there.