Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
digest group list 가져오기 기능 추가 #26
digest group list 가져오기 기능 추가 #26
Changes from all commits
74ff4ae
df32894
01fda01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반복되는 로직과 inline 스타일을 조금 지양하기 위해 아래와 같이 바꿔보았는데, 요건 어떠한지 의견 부탁드려요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moong23
DRY도 고려할 수 있긴 한데, 컴포넌트가 사실상 UI로직밖에 없는 코드잖아요?
그럼 이 코드를 읽을때 코드를 쭉 내려가다
!data.length
부분을 읽어야만 UI가 두 케이스로 나눠진다는걸 알 수 있을 것 같아요.컴포넌트 네이밍에서도 UI가 두 케이스로 나눠진다는 힌트는 없다보니 의도적으로 WET하게 작성했는데 어떻게 생각하시나요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
옹 좋네요 요 부분에 대해서는 한번도 생각을 해본적이 없어서 사고가 여기까지 확장이 안되어있었어요 좋은 방법인것같아요