Skip to content

redfish: Add redfish schemas only from implementation and oem #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

serge4k
Copy link

@serge4k serge4k commented Feb 21, 2023

Implemented logic inside the "redfish-gen" tool to prepare schemas based on BMC implementation and Oem schemas necessary for the "Redfish Service Validator" tool.

Part of BBMC-1462

End-User-Impact: Low: (The BMC's redfish service may be validated
by the "Redfish Service Validator" tool)

@serge4k serge4k force-pushed the feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem branch 2 times, most recently from 812fcbe to f9fa915 Compare February 21, 2023 09:08
Implemented logic inside the "redfish-gen" tool to prepare schemas based on BMC implementation
and Oem schemas necessary for the "Redfish Service Validator" tool.

Part of BBMC-1462

End-User-Impact: Low: (The BMC's redfish service may be validated
		by the "Redfish Service Validator" tool)

Signed-off-by: Sergey Gulyaev <[email protected]>
@serge4k serge4k force-pushed the feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem branch from f9fa915 to b24a80a Compare February 21, 2023 09:31
Copy link
Collaborator

@ikmsk10 ikmsk10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Codacy has several warnings, please fix them.

tools/redfish-gen/redfish_gen/redfish_schema.py Outdated Show resolved Hide resolved
Create common Redfish class with common functionality to
share same Redfish related functionaly in the 'redfish-gen'
tool.

End-User-Impact: None: (Code optimization without change
			functionality)

Signed-off-by: Sergey Gulyaev <[email protected]>
@serge4k serge4k force-pushed the feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem branch from 86166fc to 61f29d6 Compare February 27, 2023 09:46
Sergey Gulyaev added 2 commits February 27, 2023 15:35
Create common Redfish class with common functionality to
share same Redfish related functionaly in the 'redfish-gen'
tool.

Part of BBMC-1462

End-User-Impact: None: (Code optimization without change
			functionality)

Signed-off-by: Sergey Gulyaev <[email protected]>
Create common Redfish class with common functionality to
share same Redfish related functionaly in the 'redfish-gen'
tool.

Part of BBMC-1462

End-User-Impact: None: (Code optimization without change
                        functionality)

Signed-off-by: Sergey Gulyaev <[email protected]>
@serge4k serge4k force-pushed the feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem branch from d05cb58 to 6dcedd2 Compare February 27, 2023 15:18
@serge4k serge4k requested a review from ikmsk10 February 27, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants