Added checks to xrt::version api's to throw exception when information is not available #8430
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManojTakasi
changed the title
…not available Signed-off-by: Manoj Takasi <[email protected]>
ManojTakasi
force-pushed
the
kria_som
branch
from
4b96bb1
to
7623356
Compare
chvamshi-xilinx
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
In canonical/debian build for embedded platforms, we create achieve file of our source code and remove all .git files (this is standard process and .git files will not be archieved in their flow). xrt_version.cpp file we are returning typed values like uint from #def 's in xrt_version.h file which would be empty in this case because of lack of .git files.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Modified cmake to set the defualt value as 0 and added checks to version api's to throw exception when information is not available.
Risks (if any) associated the changes in the commit
low
What has been tested and how, request additional testing if necessary
tested with u250 and build_edge_deb flow
Documentation impact (if any)
NA