Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Popover add contextmenu #2166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cafkagh
Copy link

@cafkagh cafkagh commented Jul 4, 2022

  • Popover气泡卡片添加右键动作

@@ -4,7 +4,7 @@ export interface PopoverProps {
title?: string | JSX.Element
content: string | JSX.Element
placement?: 'top' | 'right' | 'bottom' | 'left'
trigger?: 'click' | 'focus' | 'hover'
trigger?: 'click' | 'focus' | 'hover' | 'right-click'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以就叫 contextmenu ,v4 已经扩展了这个功能

@cafkagh
Copy link
Author

cafkagh commented Jul 6, 2022 via email

@Flcwl
Copy link
Collaborator

Flcwl commented Jul 6, 2022

我是修改trigger名重提pr还是直接使用v4呢?

------------------ 原始邮件 ------------------ 发件人: "XiaoMi/hiui" @.>; 发送时间: 2022年7月5日(星期二) 晚上9:32 @.>; @.@.>; 主题: Re: [XiaoMi/hiui] feat: add right-click (PR #2166) @Flcwl approved this pull request. In components/popover/index.d.ts: > @@ -4,7 +4,7 @@ export interface PopoverProps { title?: string | JSX.Element content: string | JSX.Element placement?: 'top' | 'right' | 'bottom' | 'left' - trigger?: 'click' | 'focus' | 'hover' + trigger?: 'click' | 'focus' | 'hover' | 'right-click' 可以就叫 contextmenu ,v4 已经扩展了这个功能 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

@cafkagh 可以使用 v4 的 @hi-ui/popover,目前v3正在归档处理,非特殊情况暂时不考虑更新版本~

npm i @hi-ui/popover@feature

@cafkagh cafkagh changed the title feat: add right-click feat: Popover add contextmenu Jul 6, 2022
@cafkagh cafkagh requested a review from Flcwl July 8, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants