Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Godsil-Gutman estimator #392

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aleksey-uvarov
Copy link

Context:
Randomized estimators of the Hafnian of a nonnegative matrices can be implemented in two different manners. Previously hafnian_approx() only implemented one of them

Description of the Change:
Added an option to use the Godsil-Gutman estimator. Also changed the signature of hafnian() so that now all methods are controlled by the method parameter, and the approx parameter is removed as redundant.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@nquesada
Copy link
Collaborator

Hi, could you address this two minor issues detected by the bots:
image

thewalrus/_hafnian.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants