Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Promote FormField from Preview to Main #2934

Draft
wants to merge 3 commits into
base: prerelease/major
Choose a base branch
from

Conversation

mannycarrera4
Copy link
Contributor

Summary

Fixes: #1934

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4 mannycarrera4 self-assigned this Sep 20, 2024
@mannycarrera4 mannycarrera4 added this to the 12.0.0 milestone Sep 20, 2024
Copy link

cypress bot commented Sep 20, 2024

Workday/canvas-kit    Run #7781

Run Properties:  status check passed Passed #7781  •  git commit 4a6729f925 ℹ️: Merge 021243dd80fc25f019378a8e74e5c55aa9241010 into 19a43f88e6d0db8567ae0afb0e41...
Project Workday/canvas-kit
Branch Review mc-promote-formfield
Run status status check passed Passed #7781
Run duration 03m 28s
Commit git commit 4a6729f925 ℹ️: Merge 021243dd80fc25f019378a8e74e5c55aa9241010 into 19a43f88e6d0db8567ae0afb0e41...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 15
Tests that did not run due to a developer annotating a test with .skip  Pending 16
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 854
View all changes introduced in this branch ↗︎
UI Coverage  21.6%
  Untested elements 1620  
  Tested elements 444  
Accessibility  99.16%
  Failed rules  5 critical   5 serious   0 moderate   2 minor
  Failed elements 148  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant