Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that doesn't 'fail open' if existing providers poof. #586

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ensure that doesn't 'fail open' if existing providers poof. #586

wants to merge 8 commits into from

Commits on Aug 24, 2023

  1. Ensure that doesn't 'fail open' if existing providers poof. 

    This also ensures if a user only had U2F enabled, and it's deprecated and removed, that it won't "fail open" for lack of any available methods.

If Email is available, shove it in.  If not, return an error.
    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c79bbcc View commit details
    Browse the repository at this point in the history

  2. Do the fallback slightly downstream.

    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    bd676f9 View commit details
    Browse the repository at this point in the history

  3. Handle the WP_Error fail cases

    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9ad6dd6 View commit details
    Browse the repository at this point in the history

  4. Add a unit test for this.

    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c9aa7ac View commit details
    Browse the repository at this point in the history

  5. Ensure we're comparing the keys. 

    The return value uses the class as keys, and the object as the value.
    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a745c3c View commit details
    Browse the repository at this point in the history

  6. Use a class that won't get stripped out. 

    TOTP being unconfigured stripped it out otherwise.
    @georgestephanis
    georgestephanis committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f8c780d View commit details
    Browse the repository at this point in the history

  7. Update the error messages for understandability. 

    Co-authored-by: Timothy Jacobs <[email protected]>
    @georgestephanis @TimothyBJacobs
    georgestephanis and TimothyBJacobs committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2e616ea View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'master' into add/fallback-email

    @dd32
    dd32 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    947afdd View commit details
    Browse the repository at this point in the history