Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS: closures not using $this should be static #2363

Merged
merged 1 commit into from
Aug 19, 2023
Merged

CS: closures not using $this should be static #2363

merged 1 commit into from
Aug 19, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Aug 18, 2023

Inspired by #2362 (review) - this fixes up the other closures in the code base.

@jrfnl jrfnl added this to the 3.0.0 milestone Aug 18, 2023
GaryJones
GaryJones approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@GaryJones GaryJones merged commit 4e8f340 into develop Aug 19, 2023
40 checks passed
@GaryJones GaryJones deleted the feature/cs-closures-should-be-static branch August 19, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones approved these changes

@dingo-d dingo-d dingo-d approved these changes

Assignees
No one assigned
Labels
Type: Chores/Cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrfnl @GaryJones @dingo-d