Helpers: add some more defensive coding #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Helper` classes containing stand-alone `static` methods can be used by both WPCS itself as well as external standards extending WPCS. As these methods have been made stand-alone, they should probably contain a little more defensive coding in select places. Note: this code will not be "covered" by tests at this moment as the WPCS code as-is will never hit these conditions. At a later point in time, we may want to add dedicated tests for the Helper methods which aren't moving to PHPCSUtils. When we do, we can make sure this defensive code gets covered too.
jrfnl
force-pushed
the
feature/helpers-add-extra-defensive-coding
branch
from
cee7da5
to
2e0c47a
Compare
GaryJones
approved these changes
Jun 29, 2023
dingo-d
reviewed
Jul 4, 2023
dingo-d
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Helperclasses containing stand-alonestaticmethods can be used by both WPCS itself as well as external standards extending WPCS.As these methods have been made stand-alone, they should probably contain a little more defensive coding in select places.
Note: this code will not be "covered" by tests at this moment as the WPCS code as-is will never hit these conditions.
At a later point in time, we may want to add dedicated tests for the Helper methods which aren't moving to PHPCSUtils. When we do, we can make sure this defensive code gets covered too.