Improve consistency in method names across Helpers #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss Helpers For the stand-alone Helper classes which only contain one "functions list" array property, name the retrieval method `get_functions()`. After all, these are not traits, which run a risk of a class `use`-ing the trait overloading the method and as the method is `static`, the class name used in the function call already clearly indicates _which_ function list is being retrieved.
… Helpers For the stand-alone Helper classes which only contain one "functions list" array property, name the retrieval method `get_functions()`. After all, these are not traits, which run a risk of a class `use`-ing the trait overloading the method and as the method is `static`, the class name used in the function call already clearly indicates _which_ function list is being retrieved.
|
Note: The |
GaryJones
approved these changes
Jun 29, 2023
dingo-d
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayWalkingFunctionsHelper: improve consistency in method names across Helpers
For the stand-alone Helper classes which only contain one "functions list" array property, name the retrieval method
get_functions().After all, these are not traits, which run a risk of a class
use-ing the trait overloading the method and as the method isstatic, the class name used in the function call already clearly indicates which function list is being retrieved.UnslashingFunctionsHelper: improve consistency in method names across Helpers
For the stand-alone Helper classes which only contain one "functions list" array property, name the retrieval method
get_functions().After all, these are not traits, which run a risk of a class
use-ing the trait overloading the method and as the method isstatic, the class name used in the function call already clearly indicates which function list is being retrieved.