WP/PostsPerPage: bug fix - allow for explicitly positive numbers

This prevents false negatives when the number given is explicitly positive. Includes tests.
WordPress · Jul 4, 2023 · 0ececb6 · 0ececb6
1 parent 0d37c0c
commit 0ececb6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/WordPress/Sniffs/WP/PostsPerPageSniff.php b/WordPress/Sniffs/WP/PostsPerPageSniff.php
@@ -69,7 +69,7 @@ public function getGroups() {
 	 */
 	public function callback( $key, $val, $line, $group ) {
 		$val = TextStrings::stripQuotes( $val );
-		if ( preg_match( '`^[-]?[0-9]+$`', $val ) !== 1 ) {
+		if ( preg_match( '`^[+-]?[0-9]+$`', $val ) !== 1 ) {
 			// Not a purely numeric value, so any comparison would be a false comparison.
 			return false;
 		}

diff --git a/WordPress/Tests/WP/PostsPerPageUnitTest.inc b/WordPress/Tests/WP/PostsPerPageUnitTest.inc
@@ -102,3 +102,9 @@ $query_args['posts_per_page'] = '1e3'; // Should be ignored as undetermined. Wou
 $query_args['posts_per_page'] = '50'; // OK.
 $query_args['posts_per_page'] = '200'; // Bad.
 $query_args['posts_per_page'] = "200"; // Bad.
+
+// Verify handling of explicitly positive numbers.
+$args = array(
+	'posts_per_page' => +50, // OK.
+	'posts_per_page' => +200, // Bad.
+);
diff --git a/WordPress/Tests/WP/PostsPerPageUnitTest.php b/WordPress/Tests/WP/PostsPerPageUnitTest.php
@@ -62,6 +62,7 @@ public function getWarningList() {
 			82  => 1,
 			103 => 1,
 			104 => 1,
+			109 => 1,
 		);
 	}
 }