Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Invite option when search result is empty #344

Open
wants to merge 1 commit into
base: veranda
Choose a base branch
from
Open

Display Invite option when search result is empty #344

wants to merge 1 commit into from

Conversation

kb0304
Copy link
Collaborator

@kb0304 kb0304 commented May 12, 2019

Closes #268

@jaytat0
Copy link

jaytat0 commented May 13, 2019

@kb0304 there's been a change of feeling on this in that it seems like it should still say something about the search being empty. Also can you change it to "No Results Found" instead of "No Contacts Found" ? Thanks. Sorry for the backtrack.

@kb0304
Copy link
Collaborator Author

kb0304 commented May 29, 2019 •
edited
Loading

@jaytat0 Is the above final UI that we want?
I remember us having some discussion after this comment, do you remember what was finalised?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always show the "Invite friend via another app" header
2 participants
@kb0304 @jaytat0