build.rs: fix println #852
Annotations
17 errors and 2 warnings
single-character string constant used as pattern:
src/driver/memflow.rs#L57
error: single-character string constant used as pattern
--> src/driver/memflow.rs:57:33
|
57 | .split_once("=")
| ^^^ help: try using a `char` instead: `'='`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `-D clippy::single-char-pattern` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`
|
deref which would be done by auto-deref:
src/driver/memflow.rs#L45
error: deref which would be done by auto-deref
--> src/driver/memflow.rs:45:62
|
45 | create_connector_args.insert("name", &*init_params.common.unwrap().vm_name);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&init_params.common.unwrap().vm_name`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::explicit_auto_deref)]`
|
replacing an `Option` with `None`:
src/driver/kvm.rs#L347
error: replacing an `Option` with `None`
--> src/driver/kvm.rs:347:26
|
347 | let kvmi_event = mem::replace(&mut self.vec_events[vcpu_index], None).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.vec_events[vcpu_index].take()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none
= note: `-D clippy::mem-replace-option-with-none` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::mem_replace_option_with_none)]`
|
use of a fallible conversion when an infallible one could be used:
src/driver/kvm.rs#L346
error: use of a fallible conversion when an infallible one could be used
--> src/driver/kvm.rs:346:44
|
346 | let vcpu_index: usize = event.vcpu.try_into()?;
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `usize` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/kvm.rs#L326
error: use of a fallible conversion when an infallible one could be used
--> src/driver/kvm.rs:326:46
|
326 | let vcpu_index: usize = vcpu.try_into()?;
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `usize` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/kvm.rs#L133
error: use of a fallible conversion when an infallible one could be used
--> src/driver/kvm.rs:133:47
|
133 | kvm.vec_events.resize_with(vcpu_count.try_into()?, || None);
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `usize` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L381
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:381:22
|
381 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L376
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:376:22
|
376 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L371
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:371:22
|
371 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L366
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:366:22
|
366 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L361
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:361:22
|
361 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L356
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:356:22
|
356 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
use of a fallible conversion when an infallible one could be used:
src/driver/xen.rs#L351
error: use of a fallible conversion when an infallible one could be used
--> src/driver/xen.rs:351:22
|
351 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `u16` to `u32` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/driver/xen.rs#L188
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/driver/xen.rs:188:17
|
188 | count_mut as u64
| ^^^^^^^^^^^^^^^^ help: try: `count_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/driver/xen.rs#L185
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/driver/xen.rs:185:42
|
185 | let write_len = if (offset + count_mut as u64) > u64::from(PAGE_SIZE) {
| ^^^^^^^^^^^^^^^^ help: try: `count_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/driver/xen.rs#L145
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/driver/xen.rs:145:46
|
145 | let read_len = if (page_offset + count_mut as u64) > u64::from(PAGE_SIZE) {
| ^^^^^^^^^^^^^^^^ help: try: `count_mut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
field `dom_name` is never read:
src/driver/xen.rs#L33
error: field `dom_name` is never read
--> src/driver/xen.rs:33:5
|
29 | pub struct Xen {
| --- field in this struct
...
33 | dom_name: String,
| ^^^^^^^^
|
= note: `Xen` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
book
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
book
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|