Make birthdate optional and less precise #1397
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 60.00% 61.11% +1.11%
==========================================
Files 94 94
Lines 9111 9164 +53
Branches 1641 1658 +17
==========================================
+ Hits 5467 5601 +134
+ Misses 3208 3111 -97
- Partials 436 452 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Visually reviewed, and it mostly looks okay; however I do have a question about the Alembic migration... if we're altering if nulls are permitted in columns, doesn't that cause an issue if the downgrade needs to be run for any records where a null is present for the birthday?
(Unsure if this is actually an issue, but it's just something I observed when looking at the changeset.)
|
Thanks for the review, kfkitsune! I might try to add a few more tests before deploying this. |
I want to line some up horizontally, and it’s more readable this way anyway. Hopefully it doesn’t break anything.
…that still expect it
or fuzzy, as it were - Reduces friction when signing up - Reduces amount of personal information stored by default - Keeps exact birthdate private in case people don’t realize that displaying their age is equivalent to displaying their birthdate, as long as the transition is recorded We still prevent users from displaying an age that’s inconsistent with anything they’ve done with ratings, and from changing their age once set. TODO: `asserted_adult` should be filled in for existing users just in case their birthdate is removed by site staff.
I didn’t remove it from the `request.web_input` call in the controller.
charmander
force-pushed
the
signup-no-birthdate
branch
from
1f68676
to
0f4ea03
Compare
charmander
force-pushed
the
signup-no-birthdate
branch
from
0f4ea03
to
1def20e
Compare
We still prevent users from displaying an age that’s inconsistent with anything they’ve done with ratings, and from changing their age once set.