Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run authenticate in get_authentication_errors #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamsilverstein
Copy link

Fixes an issue where logged in users could not authenticate requests with their OAuth credentials.

  • Removes hooking of authenticate on determin_current_user (which doesn't run or runst too late when the user presents login cookies)
  • Instead, authenticate directly in rest_authentication_errors callback

Fixes an issue where logged in users could not authenticate requests with their OAuth credentials.

* Removes hooking of `authenticate` on `determin_current_user` (which doesn't run or runst too late when the user presents login cookies)
* Instead, authenticate directly in `rest_authentication_errors` callback
@adamsilverstein
Copy link
Author

any option on this @rmccue? it fixes the logged in user issue.

@kosso
Copy link
Contributor

kosso commented Mar 10, 2016

I think this might have got fixed in here : 662c9f8

All OAuth tests seem to be working for me now.

My cobbled-together test script is here : https://gist.github.com/kosso/71c957e30a40116e5f98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants