spec: Move over the config/IG code changes from Private Aggregation spec. #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2024 10:51
Right now Private Aggregation monkey patches us a lot to implement our integration. This moves over the most mundane of the changes --- parsing of new IG and AuctionConfig fields --- to reduce the size of the monkeypatch and to practive how the process works. It's moved basically unchanged (except different indent/wrapping); I think the only substantative change is using our origin parser. https://github.com/morlovich/private-aggregation-api/tree/move-stuff-to-pa has the other half, it likely needs something with imports (I hope adding export to auction config/interest group on our end will help).
|
@alexmturner this will likely need your involvement as well. |
alexmturner
approved these changes
Oct 9, 2024
| @@ -82,6 +82,11 @@ spec: Fenced Frame; urlPrefix: https://wicg.github.io/fenced-frame/ | |||
| spec: Private Aggregation API; urlPrefix: https://patcg-individual-drafts.github.io/private-aggregation-api | |||
There was a problem hiding this comment.
nit: I wonder if this should have spec: private-aggregation-api so that it isn't duplicated at the bottom in Terms defined by reference
|
|
||
| Issue: Consider validating the case where the bucket used (after summing) is too large. | ||
| Currently, the implementation appears to overflow. See | ||
| <a href="https://github.com/WICG/turtledove/issues/1040">protected-audience/1040</a>. |
There was a problem hiding this comment.
nit: Update to match other issues, i.e. (<a href="https://github.com/WICG/turtledove/issues/1040">WICG/turtledove#1040</a>)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Private Aggregation monkey patches us a lot to implement our integration. This moves over the most mundane of the changes --- parsing of new IG and AuctionConfig fields --- to reduce the size of the monkeypatch and to practive how the process works.
It's moved basically unchanged (except different indent/wrapping); I think the only substantative change is using our origin parser.
https://github.com/morlovich/private-aggregation-api/tree/move-stuff-to-pa has the other half, it likely needs something with imports (I hope adding export to auction config/interest group on our end will help).
Preview | Diff