Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inspect() error and complete callbacks #176

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix inspect() error and complete callbacks #176

merged 1 commit into from
Sep 21, 2024

Conversation

domfarolino
Copy link
Collaborator

@domfarolino domfarolino commented Sep 21, 2024 •
edited by pr-preview bot
Loading

This fixes #174 to make the spec match the implementation, which is what the web platform tests expect. The proposal to use TC39's explicit resource management proposal will be considered in #150 as a follow-up.

Preview | Diff

@domfarolino domfarolino changed the title Fix inspect error and complete callbacks Fix inspect() error and complete callbacks Sep 21, 2024
@domfarolino domfarolino mentioned this pull request Sep 21, 2024
Closed
@domfarolino domfarolino merged commit a56ef28 into master Sep 21, 2024
2 checks passed
@domfarolino domfarolino deleted the fix-inspect branch September 21, 2024 22:30
github-actions bot added a commit that referenced this pull request Sep 21, 2024
@domfarolino @github-actions
Fix inspect() error and complete callbacks (#176)
1229934 
SHA: a56ef28
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error callback / complete callback are not actually used in inspect
1 participant
@domfarolino