Dbsc(e) #67
Merged
Dbsc(e) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halflumi
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
peterzenz
reviewed
Aug 16, 2024
DBSCE/KeyGeneration.md
Outdated
| @@ -0,0 +1,91 @@ | |||
| ### Local key helper on Windows | |||
|
|
|||
| On Windows, a Local key helper is a COM class. A COM interface that the local key helper implements is TBD (working name for this document is ILocalKeyHelper) | |||
There was a problem hiding this comment.
is a COM class per domain? Or the same class registered for multiple domains? Could I use *.contoso.com in the example below on line 33?
peterzenz
reviewed
Aug 16, 2024
DBSCE/KeyGeneration.md
Outdated
|
|
||
|  | ||
|
|
||
| When the browser needs to communicate with a local key helper. It uses its ID to locate the registry key, then reads the default value of this registry key and activates the object by the activation scheme (CLSID or ProgId according to the document). After activation it queries ILocalKeyHelper interface and invokes corresponding methods. |
There was a problem hiding this comment.
"It uses it's ID" Is this a new sentence or should this be a continuation of the one before. We have a few IDs in the doc. CLSID, ProgId, LocalKeyHelperId, API Activation ID. I'm assuming here it's a match on the LocalKeyHelperId. We can also answer the matching question here. Could we register *.login.com and have it match www.login.com, foo.login.com, or just login.com?
oldalton
reviewed
Aug 16, 2024
sameerag
commented
Aug 19, 2024
oldalton
suggested changes
Aug 29, 2024
Closed
oldalton
reviewed
Sep 5, 2024
alextok
reviewed
Sep 18, 2024
| - Steps 1-16 specify the key generation process for a public local key helper. The binding statement is expected to be short lived as elaborated in the [high level design](#high-level-design). | ||
| - Steps 17-29 are [DBSC](https://github.com/wicg/dbsc) with additional parameters introduced with DBSC(E). | ||
|
|
||
|  |
There was a problem hiding this comment.
maybe after conference, but I like coloring you've used in High Level design part, blue and black. IMHO, it was more readable.
alextok
reviewed
Sep 18, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 19, 2024
SHA: ede2488 Reason: push, by sameerag Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to halflumi/dbsc
that referenced
this pull request
Sep 20, 2024
SHA: ede2488 Reason: push, by halflumi Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the existing DBSC proposal to address enterprise cookie binding.