Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Permissions Policy’s "Parse policy directive" algorithm #107

Closed
wants to merge 2 commits into from

Conversation

eeeps
Copy link
Collaborator

@eeeps eeeps commented Apr 13, 2022

This makes the link work (following what I did here:

running [[permissions-policy#algo-should-request-be-allowed-to-use-feature]] given |request| and
), but I think the real fix is to get Permissions Policy to do something (add abstract-op?) to it's <dfn>s, e.g., here: https://github.com/w3c/webappsec-permissions-policy/blob/fa9e382b271a4f0694b0ed5810aad88e0eb48d09/index.bs#L794


Preview | Diff

@yoavweiss
Copy link
Collaborator

@clelland - thoughts on turning the permission-policy dfn to abstract-op and/or exporting it?

@clelland
Copy link
Collaborator

Given that we need this in CH-infra, and I think that @jarryd999 may be working on some other integrations that would require parsing, exporting makes sense. And if we're going to do that, I should change all of the algorithms to abstract-op.

@eeeps
Copy link
Collaborator Author

eeeps commented Apr 13, 2022

Ok, changed all of the links in this PR to be links to abstract ops (which it currently can't find... and I'm not sure I did it correctly... I'll try to make a PR over in Permissions Policy and then check). Don't merge this until Permissions Policy is exporting as algorithms and we can verify that the links are working.

@arichiv
Copy link
Collaborator

arichiv commented Apr 20, 2022

The latter has already been fixed and the former two are about to be re-written by me as part of #108

You can re-open and rebase if you want (and I would accept), but I'll also be getting to this soon.

@arichiv arichiv closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants