sep-workers-by-type-sidekiq-env #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NCY = 1, so I can test that this works, just like production has it set
…he dev user will still see the pattern and know how to use it
…so tried getting the variable excluded, and then try to include it the same way, but that didnt work. So now trying to explicitly add it back to pass to the deployment - heavy sigh -
… needed for more overrides
…v takes precedence
…he worker script. And only set that env variable in the importWorker so that the reg worker will just use the default or one set in the deployment extraEnvVars
|
Deployed successfully to demo and see that the correct amount of threads are correct as expected form the deploy. |
orangewolf
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to establish a pattern of passing the variables from both the original workers extraEnvVars and the import workers extraEnvVars