Merge develop into main to push some new features #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | SMTP credentials | 3790c89 | ops/alpha-deploy.tmpl.yaml | View secret |
| 8978162 | Triggered | Username Password | 238a8b5 | .env | View secret |
| 8978162 | Triggered | Username Password | 29e5cae | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Valkyrie models
I93 bulkrax upgrade
This commit will replace all instances of AdminSet.find_or_create_default_admin_set_id with Hyrax::AdminSetCreateService.find_or_create_default_admin_set.id.to_s because the former was deprecated.
I75 cleanup upgrade
This commit will fix various specs that were failing because of the Ruby 3.2.2 upgrade. At this point there should only be 4 failures left. ``` 879 examples, 4 failures, 38 pending Failed examples: rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:92 rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:87 rspec ./spec/models/bulkrax/pbcore_xml_entry_spec.rb:169 rspec ./spec/services/aapb/batch_ingest/csv_reader_spec.rb:30 ```
This commit pulls in the changes for the PbcoreXMLEntry spec from develop that passes.
In a previous commit where we removed support for rails 5.1 we forgot to copy over the view directory.
…97-bulkrax-meets-valkyrie
🧹 restore view directory
This work is still in progress. The valkyrie config file is commented out until we receive code for implementing adapters. We are using the object_factory config to utilize Valkyrie::ObjectFactory and lastly we added some changed to avoid errors when running an import. Issue: - scientist-softserv#97 Co-Authored-By: Kirk Wang <[email protected]> Co-Authored-By: LaRita Robinson <[email protected]>
replaced .empty? to .blank?
conditional check for nil or blank to avoid nil:NilClass errors
undo what I did
added new annotationType as a method
adding new annotation as a method here too
adding ams1_legacy_metadata here too
Update annotation_types.yml
Also, * Adds conditionals to only include Bulkrax transaction steps if Bulkrax is enabled. * Use work_resource.create_with_bulkrax_behavior Container if enabled. * Use change_set.create_work if not enabled. * Ignores local Sony Ci and Kubeconfig credential files based on default naming conventions and locations Co-authored-by: Benjamin Kiah Stroud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.