Defer unmount() calls in autocomplete/tooltips to fix race condition

Vyxal · Sep 16, 2024 · 76d122c · 76d122c
1 parent d61857a
commit 76d122c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/latest/scripts/Editor.tsx b/src/latest/scripts/Editor.tsx
@@ -80,7 +80,7 @@ export default function Editor({ code, ratio, children, setCode, theme, literate
         return { dom, top: true };
     }), []);
 
-    const extensions = [...useMemo(() => EXTENSIONS.concat([literate ? vyxalLit(elementData!) : vyxal(util, elementData!)]), [literate]), header];
+    const extensions = useMemo(() => EXTENSIONS.concat(literate ? vyxalLit(elementData!) : vyxal(util, elementData!), header), [literate]);
     return <div style={{ height: ratio, overflow: "auto", position: "relative" }}>
         <ErrorBoundary FallbackComponent={EditorError}>
             <ReactCodeMirror

diff --git a/src/latest/scripts/extensions/common.ts b/src/latest/scripts/extensions/common.ts
@@ -21,7 +21,7 @@ function elementCompletion(thing: SyntaxThing, literate: boolean): Completion {
             return {
                 dom: container,
                 destroy() {
-                    root.unmount();
+                    setTimeout(() => root.unmount());
                 },
             };
         },
@@ -88,7 +88,7 @@ export function elementTooltip(elementData: ElementData, literate: boolean) {
                     return {
                         dom: container,
                         destroy() {
-                            root.unmount();
+                            setTimeout(() => root.unmount());
                         },
                     };
                 },