Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exporting to a Maven project #3003

Merged
merged 57 commits into from
Aug 9, 2024

Conversation

yadavan88
Copy link
Contributor

@yadavan88 yadavan88 commented Jul 5, 2024

Export scala-cli project to Maven build with simple pom.xml.
Currently, implementation is done only for java projects

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Make sure to reformat and regenerate reference docs, so that the CI stops complaining about it.
Also, I know it's WIP, but I don't think the pom.xml logic is used atm, you're still generating an SBT project when --maven is passed.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments while going through the current progress.

build.sc Outdated Show resolved Hide resolved
@Gedochao Gedochao changed the title [WIP] Option to export pom file for a Java Project [WIP] Add support for Maven export Aug 7, 2024
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good already, we just need a couple tweaks. Great contribution!

@Gedochao Gedochao changed the title [WIP] Add support for Maven export Add support for exporting to a Maven project Aug 9, 2024
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of things can still be done to polish the solution, but we can do those as a follow-ups.
LGTM, great contribution!

Extracted issues:

@Gedochao Gedochao merged commit 7c08b92 into VirtusLab:main Aug 9, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants