Add constructor definition for QueryBuilder class for typescript inheritance

[ralcorta]

To allow inheritance from the QueryBuilder class and use the constructor method, we must add the constructor definition in index.d.ts

[ankitr]

Would love to know what the type signature of the constructor is supposed to be. Looks like it's a ModelClass?

[ralcorta]

Would love to know what the type signature of the constructor is supposed to be. Looks like it's a ModelClass?

Hi @ankitr ! The idea of this is like this:
I was trying to do a BaseQueryBuilder in Typescript to manage the soft delete for all of my models, and I found that I cannot extend de constructor of QueryBuilder class like this:

export class BaseQueryBuilder<M extends Model, R = M[]> extends QueryBuilder<M, R> {

  // ...

  constructor(...args: any[]) {
    super(...args);
    this._handleSoftDelete();
  }

  // ... more code

}

This works on Javascript, but don't work in Typescript.
The solution was add the constructor(...args: any[]): this; on the QueryBuilder class (This change), and that was it.
I've seen several packages out there trying to do it but always in a bit complicated ways and not covering all the cases because they can't add logic in the Query Builder's constructor.

With this constructor typed, I guess people will be able to extend more functionalities to the queryBuilder strategy.

[ralcorta]

@ankitr Hello! It was a long time ago, but it's still a good approach. What do you think? I have a package from a fork with this change, good to check.

[ralcorta]

@ankitr is this a forgotten repo or issue?

[lehni]

There are a lot of unnecessary formatting changes in this PR, making a review difficult, and I will not merge it in this state. Could you change it so that only the lines that actually need to change are included?