Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #591

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Improve README #591

wants to merge 23 commits into from

Conversation

Tiagoquix
Copy link
Contributor

No description provided.

@PolisanTheEasyNick
Copy link
Contributor

PolisanTheEasyNick commented May 8, 2024

Probably good idea would be to change ScreenSharing screenshot in this PR too, because in #489 we greatly changed UI for ScreenSharing settings on Linux and MacOS systems.

@Tiagoquix
Copy link
Contributor Author

Good idea.

@Tiagoquix
Copy link
Contributor Author

The Windows screenshare was also changed with a recent PR.

@Vendicated
Copy link
Member

looks good for the most part but i dislike moving the screenshots down

screenshots should usually be on the top

@Tiagoquix
Copy link
Contributor Author

Current screenshots are too large to be on top, making them a nuisance when trying to scroll down to read about Vesktop's features.

Resizing them doesn't help because they aren't the same size, so it looks a little out-of-place. That's why I put them at the bottom.

What do you think about screenshots on top but with something like "Click to expand"?

@Curve
Copy link
Member

Curve commented Jun 1, 2024

Current screenshots are too large to be on top, making them a nuisance when trying to scroll down to read about Vesktop's features.

Resizing them doesn't help because they aren't the same size, so it looks a little out-of-place. That's why I put them at the bottom.

What do you think about screenshots on top but with something like "Click to expand"?

Put them in a table

@Tiagoquix
Copy link
Contributor Author

Current screenshots are too large to be on top, making them a nuisance when trying to scroll down to read about Vesktop's features.
Resizing them doesn't help because they aren't the same size, so it looks a little out-of-place. That's why I put them at the bottom.
What do you think about screenshots on top but with something like "Click to expand"?

Put them in a table

I don't know how to do it. Feel free to contribute to https://github.com/Tiagoquix/Vesktop/tree/main.

@Tiagoquix
Copy link
Contributor Author

Tiagoquix commented Jun 9, 2024

@Vendicated hi there, please review the new changes https://github.com/Tiagoquix/Vesktop/blob/main/README.md

thanks in advance!

screenshots are from #568 + the existing settings page screenshot
also added licensing section

@Tiagoquix
Copy link
Contributor Author

PR is now shiggier thanks to Noah!


<table>
<tr>
<th colspan="3">Linux Screenshare</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

focuses a bit too much on linux... there should also be one image that just shows normal discord

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all-hail the penguin! 🐧

I agree, we should have more screenshots: normal Discord, user settings and maybe vencord settings too, then screenshare

It's nicer. :)
Also it's consistent with other places (such as "Restart Client" in Vencord's settings).
This reverts commit c640045.

Wrong branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants