[FIX] csv2xml: Error when the module with csv folder has __openerp__py file. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py file. When the odoo's module has a __openerp__.py file, occurs a error because the if for check if the __openerp__.py file exists is fine, but, the next if checks again the __manifest__.py file and not should, because the __openerp__.py file already have been checked
|
@zaoral Do you agree with this change? |
yaniaular
force-pushed
the
0.1-fix_issue_2-dev-yani
branch
2 times, most recently
from
6111f5b
to
95f13b9
Compare
|
@moylop260 Please, do you can me help to merge this? |
luistorresm
reviewed
Jun 21, 2017
csv2xml/csv2xml.py
Outdated
| @@ -452,7 +452,7 @@ def fix_module_name(path): | |||
| manifest_file = os.path.join(path, '__manifest__.py') | |||
| if os.path.exists(openerp_file) and os.path.isfile(openerp_file): | |||
| pass | |||
| if os.path.exists(manifest_file) and os.path.isfile(manifest_file): | |||
| elif os.path.exists(manifest_file) and os.path.isfile(manifest_file): | |||
There was a problem hiding this comment.
What do you think about this change:
if not (os.path.exists(openerp_file) and os.path.isfile(openerp_file)) and not (os.path.exists(manifest_file) and os.path.isfile(manifest_file)):
msg = ('The given module is not a openerp module. Missing'
' __openerp__.py or __manifest__.py file.') ' __openerp__.py or __manifest__.py file.')
raise argparse.ArgumentTypeError(msg) raise argparse.ArgumentTypeError(msg)
return path return path
To avoid the pass?
yaniaular
force-pushed
the
0.1-fix_issue_2-dev-yani
branch
from
44b9c74
to
14e4279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2
When the odoo's module has a
__openerp__.pyfile, occurs a error because the if for check if the__openerp__.pyfile exists is fine, but, the next if checks again the__manifest__.pyfile and not should, because the__openerp__.pyfile already have been checked