reshade: Summarise code-section of ReshadeUniform::copy
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Lambdas use common variable array name
* Inlined multi-lined statements into single-lined expressions * Use understore to denote x_detail lambda function
|
Neat :) I'll try and peek at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR condenses and summaries some common code-fragments in
ReshadeUniform::copy.I would squash this to one commit, however I kept the history for code-review ease and purposes. Please feel free when this PR is fine, to condense everything into one commit for git-history reasons if you like! 😄
Happy to answer any questions on the design of the changeset. The source-code uses mixed naming standards as tried to match the style previously (which was also mixed).
Hope this helps and thanks! 😄